Skip to content

Keysight B2962A: Add remote sensing parameter#7925

Merged
jenshnielsen merged 4 commits intomicrosoft:mainfrom
neildick:driver/b2962a_add_rems
Mar 18, 2026
Merged

Keysight B2962A: Add remote sensing parameter#7925
jenshnielsen merged 4 commits intomicrosoft:mainfrom
neildick:driver/b2962a_add_rems

Conversation

@neildick
Copy link
Copy Markdown
Contributor

Add the 'remote sensing' parameter to enable or disable the 4-wire output mode on a B2962A channel.

@neildick neildick requested a review from a team as a code owner March 13, 2026 00:56
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.54%. Comparing base (852c06e) to head (d40135b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...des/instrument_drivers/Keysight/Keysight_B2962A.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7925      +/-   ##
==========================================
- Coverage   60.54%   60.54%   -0.01%     
==========================================
  Files         333      333              
  Lines       32227    32230       +3     
==========================================
+ Hits        19513    19514       +1     
- Misses      12714    12716       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neildick neildick force-pushed the driver/b2962a_add_rems branch from 49813c8 to e88636c Compare March 15, 2026 22:08
@neildick
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neildick, The docs build error should be fixed if you merge or rebase main into this branch. The precommit that enforces linting and formatting needs to be run. Personally I would recommend to install prek https://prek.j178.dev/ and enable precommit hooks on the repo using that

Add the 'remote sensing' parameter to enable or disable the 4-wire
output mode on a B2962A channel.
Add type hints to the parameters within the b2962a channel so
that param.instrument can resolve the correct type.
Use the on_off_val_mapping function to be consistent with
other instruments
@neildick neildick force-pushed the driver/b2962a_add_rems branch from e88636c to 7fcdeab Compare March 17, 2026 21:31
@jenshnielsen jenshnielsen enabled auto-merge March 18, 2026 08:14
@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 18, 2026
Merged via the queue into microsoft:main with commit 115339f Mar 18, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants